Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add limited_staff to allowedRoles [BB-7834] #352

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: add limited_staff to allowedRoles [BB-7834] #352

merged 1 commit into from
Oct 10, 2023

Conversation

0x29a
Copy link
Contributor

@0x29a 0x29a commented Sep 18, 2023

Description

Users with the Course Limited Staff role, that has been added here, don't have access to the gradebook. In this PR we add this role's slug to allowedRoles.

Testing instructions

The fix is pretty trivial, so just make sure that the slug in allowedRoles is equal to CourseLimitedStaffRole.ROLE value.

@0x29a 0x29a requested a review from a team as a code owner September 18, 2023 09:01
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 18, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @0x29a! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@0x29a 0x29a changed the title fix: add limited_staff to allowedRoles [BB-7489] fix: add limited_staff to allowedRoles [BB-7834] Sep 18, 2023
0x29a added a commit to open-craft/frontend-app-gradebook that referenced this pull request Sep 18, 2023
@0x29a
fix: add limited_staff to allowedRoles
168cf24 
Backported from [here](openedx#352).
@0x29a 0x29a mentioned this pull request Sep 18, 2023
Merged
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5e96dbf) 94.93% compared to head (1514774) 94.93%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #352   +/-   ##
=======================================
  Coverage   94.93%   94.93%           
=======================================
  Files         139      139           
  Lines        1343     1343           
  Branches      264      264           
=======================================
  Hits         1275     1275           
  Misses         60       60           
  Partials        8        8
Files Changed Coverage Δ
src/data/thunkActions/roles.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. and removed needs test run Author's first PR to this repository, awaiting test authorization from Axim labels Oct 2, 2023
@leangseu-edx leangseu-edx merged commit 295048b into openedx:master Oct 10, 2023
5 checks passed
@openedx-webhooks
Copy link

@0x29a 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@0x29a 0x29a deleted the 0x29a/bb7834/fix-gradebook-access-for-limited-staff branch October 10, 2023 14:37
Agrendalath pushed a commit to open-craft/frontend-app-gradebook that referenced this pull request Oct 16, 2023
@0x29a @Agrendalath
fix: add limited_staff to allowedRoles
25bdb04 
Backported from [here](openedx#352).
Agrendalath pushed a commit to open-craft/frontend-app-gradebook that referenced this pull request Oct 16, 2023
@0x29a @Agrendalath
fix: add limited_staff to allowedRoles
cbb32d1 
Backported from [here](openedx#352).
@itsjeyd itsjeyd removed the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Nov 17, 2023
kaustavb12 pushed a commit to open-craft/frontend-app-gradebook that referenced this pull request Jun 10, 2024
@0x29a @kaustavb12
fix: add limited_staff to allowedRoles
8aa7082 
Backported from [here](openedx#352).

(cherry picked from commit cbb32d1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leangseu-edx leangseu-edx leangseu-edx approved these changes

Assignees
No one assigned
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0x29a @openedx-webhooks @leangseu-edx @itsjeyd @mphilbrick211